Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Use rspec's ruby executable for run #246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[tests] Use rspec's ruby executable for run #246

wants to merge 1 commit into from

Conversation

dafyddcrosby
Copy link
Contributor

Description

This fixes the assumption that ruby is always available from PATH.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@dafyddcrosby dafyddcrosby requested review from a team as code owners June 12, 2024 16:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dafyddcrosby
[tests] Use rspec's ruby executable for run
2c768c5 
This fixes the assumption that `ruby` is always available from PATH.

Signed-off-by: David Crosby <[email protected]>
@tpowell-progress tpowell-progress self-assigned this Jun 25, 2024
jaymzh
jaymzh requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have broken windows...

@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Sep 3, 2024
@jaymzh
Copy link
Collaborator

jaymzh commented Oct 29, 2024

@dafyddcrosby - ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@tpowell-progress tpowell-progress

Labels
Status: Waiting on Contributor A pull request that has unresolved requested actions from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dafyddcrosby @jaymzh @tpowell-progress